fix: Resolve version manually #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* exceptiongroup 1.2.1 -> 1.2.2 * importlib-metadata 7.1.0 -> 8.0.0 * packaging 24.0 -> 24.1 * zipp 3.19.1 -> 3.19.2 --- Signed-off-by: AlexNg <contact@ngjx.org>
This fixes #141 where compiling python with nuitka with --standalone flag causes runtime errors with importlib.metadata. This patch also removes the now unneeded importlib-metadata dependency Thanks to Abdullah Albanna <albannaa78@gmail.com> who raised this issue and helped out in debugging. --- Fixes #141 Co-authored-by: Abdullah Albanna <albannaa78@gmail.com> Signed-off-by: AlexNg <contact@ngjx.org>
github-actions
bot
added
the
Documentation
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Compiling python with thread included do not play nice with resolving version with
importlib.Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
[optional] Are there any post deployment tasks we need to perform?
Checklist