Skip to content

Update tests #80

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2024
Merged

Update tests #80

merged 3 commits into from
Apr 28, 2024

Conversation

caffeine-addictt
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Breaking Change
  • Documentation Update

Description

Unreverts #59 and fixes the issue where pytest was not able to find thread in CI.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have incremented the version according to semantic versioning.
  • I have updated the changelog accordingly.

caffeine-addictt and others added 3 commits April 28, 2024 14:41
@caffeine-addictt @robvdl
test: Remove src import
42aac36 
Reverting the revert of #59

Ref: #59
Ref: #61

Co-authored-by: Rob van der Linde <robvdl@gmail.com>
@caffeine-addictt
ci(test): Run pytest through poetry
c2f2214 
Might resolve the previous unresolved ci issue in #59
@caffeine-addictt
style: Conform to linting
2d963fd
@caffeine-addictt caffeine-addictt added Type: Test A problem or enhancement related to a test. Type: CI A problem or enhancement related to continuous integration. labels Apr 28, 2024
@caffeine-addictt caffeine-addictt self-assigned this Apr 28, 2024
@github-actions github-actions bot added Documentation An issue/change with the documentation. Scope: Core labels Apr 28, 2024
@caffeine-addictt caffeine-addictt merged commit 0af8777 into main Apr 28, 2024
29 checks passed
@caffeine-addictt caffeine-addictt deleted the chore/update-tests branch April 28, 2024 07:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@caffeine-addictt caffeine-addictt

Labels
Documentation An issue/change with the documentation. Type: CI A problem or enhancement related to continuous integration. Type: Test A problem or enhancement related to a test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@caffeine-addictt