-
Notifications
You must be signed in to change notification settings - Fork 68
Update the colormap HTML representation #110
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update the colormap HTML representation #110
Conversation
3cb8385
to
d215c3f
Compare
d215c3f
to
cc82787
Compare
@ocefpaf it would be great if you could consider this PR for the next release :) We'd like to use branca more in ipyleaflet |
Here is another example of the use of Branca and the custom colormap in ipyleaflet |
It looks like the maintainers are busy, we'd like to move forwards with this. |
Also happy to help with branca and folium maintenance if needed. |
Hello, is there any way of making things progress on this PR please ? Many thanks. |
I had to check, because I normally don't use the
I'll merge after the tests ran. |
I completely missed this PR and the comments here, sorry. BTW, I'd love to take on your offer here. Does that still stands? |
@ocefpaf Yeah, it does. Now that we have exposed folium in geopandas it seems beneficial to have a bit of overlap in maintenance to channel issues and fixes to the right place. And I hope it may also help shorten the release cycle of folium. |
@martinfleis I'm assuming you are in for @HaudinFlorence are you or others in your team interested too? Would that be only |
Yup. Can't promise a ton of activity but some for sure. |
I'm sure it will be more than what I have been offering these projects lately :-) |
Thanks a lot for merging the PR @ocefpaf . We might indeed mainly contribute to branca to upstream features needed in ipyleaflet |
Happy to help contribute too! |
You three should have access to branca and Martin also has access to folium. Thanks! |
@ocefpaf Can you please re regive me access to Branca. I left the organization by mistake. Thanks. |
Hello @HaudinFlorence, how do you know which colormap (viridis, plasma etc.) to use for the correct matching in your screenshots of the Heatmap and Velocity layers? Also, I am working with Shiny for Python to create a Webapp and ColormapControl doesn't seem to work in this constellation (ColormapControl created in the server function). |
Update the colormap HTML representation to match the way it renders on Folium maps.
Here is a preview of the colormap used with Choropleth layer from ipyleaflet.