allow branca ColorMap in write_png #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and make it have parity with the version in Folium, so we can remove the code there.
This was referenced Jan 22, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes python-visualization/folium#1571 and python-visualization/folium#1280, when we also merge python-visualization/folium#1708.
Users expect to be able to pass a branca
ColorMaptowrite_pngandimage_to_url. Make this possible by testing for the correct type and using thergba_floats_tuplemethods if it's a brancaColorMap. Add tests.Also include changes from folium to the same function so we can remove the duplicate code from folium.