Skip to content

Folium loads two versions of bootstrap #1908

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
bopjesvla opened this issue Mar 26, 2024 · 1 comment · Fixed by #1914
Closed

Folium loads two versions of bootstrap #1908

bopjesvla opened this issue Mar 26, 2024 · 1 comment · Fixed by #1914

Comments

@bopjesvla
Copy link

Describe the bug

Folium currently loads two versions of bootstrap:

<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/bootstrap@5.2.2/dist/css/bootstrap.min.css"/>
<link rel="stylesheet" href="https://netdna.bootstrapcdn.com/bootstrap/3.0.0/css/bootstrap.min.css"/>

To Reproduce

The first Folium iframe on https://python-visualization.github.io/folium/latest/getting_started.html contains the above snippet.

@Conengmo
Copy link
Member

Conengmo commented Apr 3, 2024

That's correct, we require Bootstrap 3 to show Glyphicons. See #1650.

But I did just notice in https://stackoverflow.com/a/18225474/4082914 they also list a css just for Glyphicons. It seems to work as well. Not sure why we didn't include that in #1650. I'll open a PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants