Drop Bootstrap 3 but keep glyphicons #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Hans for the review! |
hansthen
pushed a commit
to hansthen/folium
that referenced
this pull request
Apr 3, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1650 we transitioned from Bootstrap 3 to 5. We also had to keep Bootstrap 3 for the Glyphicon icons in the AwesomeMarkers.
Turns out there's also a hosted css file with only the css necessary for the glyphicons, not the entirety of Bootstrap 3. See https://stackoverflow.com/a/18225474/4082914 under "If you want to use the Glyphicons separately". Use that file instead.
Closes #1908.