Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Selenium test failure #2034

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Conversation

Conengmo
Copy link
Member

@Conengmo Conengmo commented Nov 27, 2024

Verified that the Selenium tests work when pinning the version of selenium to <4.27.0. In the release notes for 4.27.0 I found a mention of deprecation of GetAttribute, which corresponds to the error message we are seeing. They deprecated a method call we do in the geojson tests, see SeleniumHQ/selenium#13334.

I tried to fix it by changing that method call, but that didn't work out.

I don't have time to dive into this further, so for now just pin the Selenium version to <4.27.0.

At a glance it looks like they are grappling with something adjacent as well on the Selenium side (see SeleniumHQ/selenium#14808 and SeleniumHQ/selenium#14800) so might be best to sit tight and see in a few weeks what they came up with.

@Conengmo Conengmo marked this pull request as ready for review November 27, 2024 14:30
@Conengmo Conengmo merged commit 5205be8 into python-visualization:main Nov 27, 2024
11 checks passed
@Conengmo Conengmo deleted the fix-selenium branch November 27, 2024 15:07
@Conengmo Conengmo mentioned this pull request Nov 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants