Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add sys.last_exc, deprecate sys.last_type, sys.last_value and sys.last_traceback #102778

Closed
iritkatriel opened this issue Mar 17, 2023 · 4 comments · Fixed by #103314
Closed

Add sys.last_exc, deprecate sys.last_type, sys.last_value and sys.last_traceback #102778

iritkatriel opened this issue Mar 17, 2023 · 4 comments · Fixed by #103314
Labels
type-feature A feature request or enhancement

Comments

@iritkatriel
Copy link
Member

iritkatriel commented Mar 17, 2023 •
edited by bedevere-bot
Loading

Linked PRs
@iritkatriel iritkatriel added the type-feature A feature request or enhancement label Mar 17, 2023
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Mar 17, 2023
@iritkatriel
pythongh-102778: Add sys.last_exc, deprecate sys.last_type, sys.last_…
75e1496 
…value, sys.last_traceback
@bedevere-bot bedevere-bot mentioned this issue Mar 17, 2023
Merged
iritkatriel added a commit that referenced this issue Mar 18, 2023
@iritkatriel
gh-102778: Add sys.last_exc, deprecate sys.last_type, sys.last_value,…
e1e9bab 
…sys.last_traceback (#102779)
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Mar 19, 2023
@iritkatriel
pythongh-102778: revert changes to idlelib
5327dc6
@bedevere-bot bedevere-bot mentioned this issue Mar 19, 2023
Merged
terryjreedy pushed a commit that referenced this issue Mar 19, 2023
@iritkatriel
gh-102778: revert changes to idlelib (#102825)
4d1f033
@terryjreedy
Copy link
Member

terryjreedy commented Mar 19, 2023 •
edited
Loading

I appreciate the effort to remove the traces of string exceptions. Is there a plan to actually stop adding the old last_xxx vars to sys and accessing them in other non-IDLE stdlib modules? When they are added to sys by python itself (after unhandled exceptions), could they be added as properties with a getter that would emit a deprecation warning, or are properties for python-coded classes only?

@iritkatriel
Copy link
Member Author

Yes, I would like to eventually remove the old fields.

Since they are module level variables, I don't think they can be properties. But maybe there's something we can do through intercepting getattr on the module?

@terryjreedy terryjreedy mentioned this issue Mar 19, 2023
Closed
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this issue Mar 27, 2023
@iritkatriel @Fidget-Spinner
pythongh-102778: Add sys.last_exc, deprecate sys.last_type, sys.last_…
0d85488 
…value,sys.last_traceback (python#102779)
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this issue Mar 27, 2023
@iritkatriel @Fidget-Spinner
pythongh-102778: revert changes to idlelib (python#102825)
4746094
@iritkatriel iritkatriel reopened this Apr 6, 2023
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Apr 6, 2023
@iritkatriel
pythongh-102778: add last_exc in idlelib, to replace sys.last_type/va…
6b74907 
…lue/traceback
@iritkatriel
Copy link
Member Author

Reopening to finish idlelib.

@iritkatriel iritkatriel mentioned this issue Apr 6, 2023
Merged
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@iritkatriel @warsaw
pythongh-102778: Add sys.last_exc, deprecate sys.last_type, sys.last_…
bb6764d 
…value,sys.last_traceback (python#102779)
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@iritkatriel @warsaw
pythongh-102778: revert changes to idlelib (python#102825)
baedad9
terryjreedy pushed a commit that referenced this issue Apr 19, 2023
@iritkatriel
gh-102778: IDLE - make sys.last_exc available in Shell after traceback (
d1e4917 
#103314)

---------
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@terryjreedy
Copy link
Member

Followup issue for idlelib is #102832 .

carljm added a commit to carljm/cpython that referenced this issue Apr 20, 2023
@carljm
Merge branch 'main' into superopt
5c0a21c 
* main: (24 commits)
  pythongh-98040: Move the Single-Phase Init Tests Out of test_imp (pythongh-102561)
  pythongh-83861: Fix datetime.astimezone() method (pythonGH-101545)
  pythongh-102856: Clean some of the PEP 701 tokenizer implementation (python#103634)
  pythongh-102856: Skip test_mismatched_parens in WASI builds (python#103633)
  pythongh-102856: Initial implementation of PEP 701 (python#102855)
  pythongh-103583: Add ref. dependency between multibytecodec modules (python#103589)
  pythongh-83004: Harden msvcrt further (python#103420)
  pythonGH-88342: clarify that `asyncio.as_completed` accepts generators yielding tasks (python#103626)
  pythongh-102778: IDLE - make sys.last_exc available in Shell after traceback (python#103314)
  pythongh-103582: Remove last references to `argparse.REMAINDER` from docs (python#103586)
  pythongh-103583: Always pass multibyte codec structs as const (python#103588)
  pythongh-103617: Fix compiler warning in _iomodule.c (python#103618)
  pythongh-103596: [Enum] do not shadow mixed-in methods/attributes (pythonGH-103600)
  pythonGH-100530: Change the error message for non-class class patterns (pythonGH-103576)
  pythongh-95299: Remove lingering setuptools reference in installer scripts (pythonGH-103613)
  [Doc] Fix a typo in optparse.rst (python#103504)
  pythongh-101100: Fix broken reference `__format__` in `string.rst` (python#103531)
  pythongh-95299: Stop installing setuptools as a part of ensurepip and venv (python#101039)
  pythonGH-103484: Docs: add linkcheck allowed redirects entries for most cases (python#103569)
  pythongh-67230: update whatsnew note for csv changes (python#103598)
  ...
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Jun 1, 2023
@iritkatriel
pythongh-102778: update documentation of PyErr_PrintEx regarding sys.…
c8f6fb6 
…last_exc
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Jun 1, 2023
@iritkatriel
pythongh-102778: update documentation of PyErr_PrintEx regarding sys.…
2157f04 
…last_exc
@bedevere-bot bedevere-bot mentioned this issue Jun 1, 2023
Merged
iritkatriel added a commit that referenced this issue Jun 2, 2023
@iritkatriel
gh-102778: update documentation of PyErr_PrintEx and traceback.print_…
0dafc78 
…last() regarding sys.last_exc (#105190)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 2, 2023
@iritkatriel @miss-islington
pythongh-102778: update documentation of PyErr_PrintEx and traceback.…
de2b136 
…print_last() regarding sys.last_exc (pythonGH-105190)

(cherry picked from commit 0dafc78)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this issue Jun 2, 2023
Merged
iritkatriel added a commit that referenced this issue Jun 2, 2023
@miss-islington @iritkatriel
[3.12] gh-102778: update documentation of PyErr_PrintEx and traceback…
00fe618 
….print_last() regarding sys.last_exc (GH-105190) (#105246)

gh-102778: update documentation of PyErr_PrintEx and traceback.print_last() regarding sys.last_exc (GH-105190)
(cherry picked from commit 0dafc78)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@erlend-aasland erlend-aasland mentioned this issue Jun 6, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-102778: IDLE - make sys.last_exc available in Shell after traceback iritkatriel/cpython
2 participants
@iritkatriel @terryjreedy