Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Signature for __release_buffer__ is incorrect #104955

Closed
JelleZijlstra opened this issue May 26, 2023 · 0 comments · Fixed by #104956
Closed

Signature for __release_buffer__ is incorrect #104955

JelleZijlstra opened this issue May 26, 2023 · 0 comments · Fixed by #104956
Assignees
@JelleZijlstra
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes type-bug An unexpected behavior, bug, or error

Comments

@JelleZijlstra
Copy link
Member

JelleZijlstra commented May 26, 2023 •
edited by bedevere-bot
Loading

Currently the signature for PEP-688's __release_buffer__ method is as follows:

>>> bytearray.__release_buffer__.__text_signature__
'($self, /)'

This is incorrect; the method takes a single argument that according to the PEP should be called buffer.

Linked PRs
@JelleZijlstra JelleZijlstra added type-bug An unexpected behavior, bug, or error 3.12 bugs and security fixes 3.13 bugs and security fixes labels May 26, 2023
@JelleZijlstra JelleZijlstra self-assigned this May 26, 2023
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this issue May 26, 2023
@JelleZijlstra
pythongh-104955: Fix __release_buffer__ signature
74617c7
@JelleZijlstra JelleZijlstra mentioned this issue May 26, 2023
Merged
JelleZijlstra added a commit that referenced this issue May 26, 2023
@JelleZijlstra @kumaraditya303
gh-104955: Fix __release_buffer__ signature (#104956)
6e1eccd 
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this issue May 26, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 26, 2023
@JelleZijlstra @kumaraditya303 @miss-islington
pythongh-104955: Fix __release_buffer__ signature (pythonGH-104956)
5a9c46e 
(cherry picked from commit 6e1eccd)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
JelleZijlstra added a commit that referenced this issue May 26, 2023
@miss-islington @JelleZijlstra @kumaraditya303
[3.12] gh-104955: Fix __release_buffer__ signature (GH-104956) (#104973)
3158b4d 
(cherry picked from commit 6e1eccd)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@erlend-aasland erlend-aasland mentioned this issue Jun 6, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@JelleZijlstra JelleZijlstra

Labels
3.12 bugs and security fixes 3.13 bugs and security fixes type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-104955: Fix __release_buffer__ signature JelleZijlstra/cpython
1 participant
@JelleZijlstra