Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test_tkinter fails on refleak run due to support confusion #105077

Closed
zware opened this issue May 30, 2023 · 1 comment
Closed

test_tkinter fails on refleak run due to support confusion #105077

zware opened this issue May 30, 2023 · 1 comment
Assignees
@zware
Labels
type-bug An unexpected behavior, bug, or error

Comments

@zware
Copy link
Member

zware commented May 30, 2023 •
edited by bedevere-bot
Loading

Bug report

When running the refleak test runner (-R), test_tkinter fails on the second run due to AttributeError: module 'test.test_tkinter.support' has no attribute 'load_package_tests'. This is because test_tkinter has its own support module, which when imported overwrites the support attribute set in Lib/test/test_tkinter/__init__.py. That module should instead import specific symbols from test.support and use them directly.

Your environment

  • CPython versions tested on: main, 3.12
  • Operating system and architecture: Windows, Linux, any other

Linked PRs
@zware zware added the type-bug An unexpected behavior, bug, or error label May 30, 2023
@zware zware self-assigned this May 30, 2023
@bedevere-bot bedevere-bot mentioned this issue May 30, 2023
Merged
zware added a commit to zware/cpython that referenced this issue May 30, 2023
@zware
pythongh-105077: Fix test_tkinter refleak checking
b807168 
Use specific symbols from `test.support` to avoid having `support`
overwritten by `test_tkinter`'s own `support` submodule.
zware added a commit that referenced this issue May 30, 2023
@zware
gh-105077: Fix test_tkinter refleak checking (GH-105078)
5454db4 
Use specific symbols from `test.support` to avoid having `support`
overwritten by `test_tkinter`'s own `support` submodule.
@bedevere-bot bedevere-bot mentioned this issue May 30, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 30, 2023
@zware @miss-islington
pythongh-105077: Fix test_tkinter refleak checking (pythonGH-105078)
55edff7 
Use specific symbols from `test.support` to avoid having `support`
overwritten by `test_tkinter`'s own `support` submodule.
(cherry picked from commit 5454db4)

Co-authored-by: Zachary Ware <zach@python.org>
zware pushed a commit that referenced this issue May 30, 2023
@miss-islington
[3.12] gh-105077: Fix test_tkinter refleak checking (GH-105078) (GH-1…
7f04a15 
…05079)

Use specific symbols from `test.support` to avoid having `support`
overwritten by `test_tkinter`'s own `support` submodule.
(cherry picked from commit 5454db4)
@erlend-aasland
Copy link
Contributor

Resolved by:

@erlend-aasland erlend-aasland mentioned this issue Jun 6, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@zware zware

Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zware @erlend-aasland