Skip to content

_testexternalinspection.c doesn't check for undefined TARGET_OS_OSX #117891

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
jmroot opened this issue Apr 15, 2024 · 1 comment · Fixed by #118073
Closed

_testexternalinspection.c doesn't check for undefined TARGET_OS_OSX #117891

jmroot opened this issue Apr 15, 2024 · 1 comment · Fixed by #118073
Labels
extension-modules C modules in the Modules dir OS-mac type-bug An unexpected behavior, bug, or error

Comments

@jmroot
Copy link
Contributor

jmroot commented Apr 15, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

Similar to #117886, TARGET_OS_OSX is not defined by older macOS SDKs, and the code doesn't distinguish between it being undefined and being defined to 0.

CPython versions tested on:

3.13

Operating systems tested on:

macOS

Linked PRs
@jmroot jmroot added the type-bug An unexpected behavior, bug, or error label Apr 15, 2024
jmroot added a commit to jmroot/cpython that referenced this issue Apr 15, 2024
@jmroot
pythongh-117891: handle undefined TARGET_OS_OSX
e76913f 
This macro is not defined by older macOS SDKs, and the code previously
didn't distinguish between it being undefined and being defined to 0.
@bedevere-app bedevere-app bot mentioned this issue Apr 15, 2024
Closed
@erlend-aasland erlend-aasland added OS-mac extension-modules C modules in the Modules dir labels Apr 15, 2024
This was referenced Apr 16, 2024
Closed
Open
Merged
@ned-deily
Copy link
Member

Thanks again for the issue. As discussed in the associated PR #117887, the suggested change has been rolled up and merged in PR #118073.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
extension-modules C modules in the Modules dir OS-mac type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-114099: Modify preprocessor symbol usage to support older macOS SDKs freakboy3742/cpython
3 participants
@jmroot @ned-deily @erlend-aasland