Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Deprecation warning for ATOMIC_VAR_INIT in mimalloc #121487

Closed
cdce8p opened this issue Jul 8, 2024 · 0 comments
Closed

Deprecation warning for ATOMIC_VAR_INIT in mimalloc #121487

cdce8p opened this issue Jul 8, 2024 · 0 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@cdce8p
Copy link
Contributor

cdce8p commented Jul 8, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

ATOMIC_VAR_INIT is marked as deprecated in C17 and C++20.

/.../cpython/Include/internal/mimalloc/mimalloc/atomic.h:42:14: error: macro 'ATOMIC_VAR_INIT' has been marked as deprecated [-Werror,-Wdeprecated-pragma] (diff)
  #if !defined(ATOMIC_VAR_INIT) || (__STDC_VERSION__ >= 201710L) // c17, see issue #735
  /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/15.0.0/include/stdatomic.h:54:41: note: macro marked 'deprecated' here
  #pragma clang deprecated(ATOMIC_VAR_INIT)

This was fixed upstream but isn't included in the vendored copy.
microsoft/mimalloc@36ee5f9
microsoft/mimalloc@1325ee6
microsoft/mimalloc#735

CPython versions tested on:

3.13, CPython main branch

Operating systems tested on:

macOS

Linked PRs
@cdce8p cdce8p added the type-bug An unexpected behavior, bug, or error label Jul 8, 2024
@bedevere-app bedevere-app bot mentioned this issue Jul 8, 2024
Merged
@cdce8p cdce8p mentioned this issue Jul 8, 2024
Open
colesbury pushed a commit that referenced this issue Jul 8, 2024
@cdce8p
gh-121487: Fix deprecation warning for ATOMIC_VAR_INIT in mimalloc (g…
31873be 
…h-121488)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 8, 2024
@cdce8p @miss-islington
pythongh-121487: Fix deprecation warning for ATOMIC_VAR_INIT in mimal…
9985800 
…loc (pythongh-121488)

(cherry picked from commit 31873be)

Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
@bedevere-app bedevere-app bot mentioned this issue Jul 8, 2024
Merged
colesbury pushed a commit that referenced this issue Jul 8, 2024
@miss-islington @cdce8p
[3.13] gh-121487: Fix deprecation warning for ATOMIC_VAR_INIT in mima…
eef5c64 
…lloc (gh-121488) (#121504)

(cherry picked from commit 31873be)

Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
@cdce8p cdce8p closed this as completed Jul 8, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@cdce8p @noahbkim
pythongh-121487: Fix deprecation warning for ATOMIC_VAR_INIT in mimal…
faa4d58 
…loc (pythongh-121488)
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@cdce8p @estyxx
pythongh-121487: Fix deprecation warning for ATOMIC_VAR_INIT in mimal…
f6cc2b0 
…loc (pythongh-121488)
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cdce8p