gh-68141: Guard test_mmap.LargeMmapTests.*
with a timeout
#101774
+25
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some file systems don't support sparse files required by
test_mmap
to work with huge sizes in theory only, without extremely long and likely unsuccessful initialization of disc space.Currently
test_mmap.LargeMmapTests._make_test_file()
assumes that sparse files are unsupported on Windows and macOS but always supported on Linux. However, filesystems like ZFS available on Linux break this assumption. As a result, we should rely on difference in duration of initialization between a single sector for sparse files and many gigabytes for non-sparse files.Since
SHORT_TIMEOUT
can be changed with--timeout
, we should put a really short bar enough for 4KB page to be written even in the worst case of process management and antivirus scan (likemin(SHORT_TIMEOUT, 5.0)
).