Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix indentation in json.AttrDict REPL example #104930

Merged
merged 1 commit into from
May 25, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented May 25, 2023

This is causing the docs to be rendered incorrectly.

https://docs.python.org/3.12/library/json.html#json.AttrDict

Screenshot of current rendering

image


📚 Documentation preview 📚: https://cpython-previews--104930.org.readthedocs.build/

This is causing the docs to be rendered incorrectly.
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label May 25, 2023
@AlexWaygood
Copy link
Member Author

Confirmed that this fixes the rendering issue. Docs preview: https://cpython-previews--104930.org.readthedocs.build/en/104930/library/json.html#json.AttrDict

@AlexWaygood AlexWaygood marked this pull request as ready for review May 25, 2023 12:41
@AlexWaygood AlexWaygood requested review from hugovk and rhettinger May 25, 2023 12:42
@miss-islington
Copy link
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@AlexWaygood AlexWaygood deleted the attrdict branch May 25, 2023 13:05
@bedevere-bot
Copy link

GH-104931 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label May 25, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2023
This is causing the docs to be rendered incorrectly.
(cherry picked from commit 38539ef)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull request May 25, 2023
…104931)

Fix indentation in `json.AttrDict` REPL example (GH-104930)

This is causing the docs to be rendered incorrectly.
(cherry picked from commit 38539ef)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants