gh-89886: Properly quote Autoconf macro arguments #105062

erlend-aasland · 2023-05-29T15:44:13Z

Autoconf 2.70 macros are picky about argument quotation.

Issue: Improve and simplify configure.ac checks #89886

Autoconf 2.70 macros are picky about argument quotation.

bedevere-bot · 2023-05-29T16:21:14Z

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 80794c7 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

pyconfig.h.in

erlend-aasland · 2023-05-29T22:10:30Z

On hold until test_import and test_peg_generator issues have been resolved on main.

pyconfig.h.in

configure.ac

erlend-aasland · 2023-05-30T20:27:38Z

Thanks for the reviews, y'all!

erlend-aasland · 2023-05-30T20:28:07Z

Here's some fun reading for you: https://www.gnu.org/software/autoconf/manual/autoconf-2.71/html_node/Coding-Style.html

gpshead

thanks for taking this on.

miss-islington · 2023-05-30T21:13:12Z

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington · 2023-05-30T21:13:13Z

Sorry, @erlend-aasland, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2ea34cfb3a21182b4d16f57dd6c1cfce46362fe2 3.12

bedevere-bot · 2023-05-30T21:30:45Z

GH-105118 is a backport of this pull request to the 3.12 branch.

…n#105062) Autoconf 2.70 macros are picky about argument quotation.

…105118) Autoconf 2.70 macros are picky about argument quotation.

bedevere-bot · 2023-05-31T00:37:21Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.12 has failed when building commit af7b55d.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1102/builds/44) and take a look at the build logs.
Check if the failure is related to this commit (af7b55d) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1102/builds/44

Failed tests:

test__xxsubinterpreters

Summary of the results of the build (if available):

==

Click to see traceback logs

remote: Enumerating objects: 4, done.        
remote: Counting objects:  25% (1/4)        
remote: Counting objects:  50% (2/4)        
remote: Counting objects:  75% (3/4)        
remote: Counting objects: 100% (4/4)        
remote: Counting objects: 100% (4/4), done.        
remote: Compressing objects:  33% (1/3)        
remote: Compressing objects:  66% (2/3)        
remote: Compressing objects: 100% (3/3)        
remote: Compressing objects: 100% (3/3), done.        
remote: Total 4 (delta 1), reused 3 (delta 1), pack-reused 0        
From https://github.com/python/cpython
 * branch                  3.12       -> FETCH_HEAD
Note: switching to 'af7b55d37f10594c3aa9815e7b6f0fd8e5ca020f'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at af7b55d37f [3.12] gh-89886: Properly quote Autoconf macro arguments (#105062) (#105118)
Switched to and reset branch '3.12'

configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

Fatal Python error: drop_gil: PyMUTEX_LOCK(gil->switch_mutex) failed
Python runtime state: initialized

Thread 0x00007fc1b4c80280 (most recent call first):
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/test__xxsubinterpreters.py", line 80 in clean_up_interpreters
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/test__xxsubinterpreters.py", line 88 in tearDown
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/case.py", line 594 in _callTearDown
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/case.py", line 637 in run
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/case.py", line 690 in __call__
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/runner.py", line 240 in run
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1115 in _run_suite
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1241 in run_unittest
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 294 in _test_module
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 330 in _runtest_inner2
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 373 in _runtest_inner
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 248 in _runtest
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 278 in runtest
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 365 in rerun_failed_tests
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 783 in _main
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 738 in main
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 802 in main
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/__main__.py", line 2 in <module>
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/runpy.py", line 88 in _run_code
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/runpy.py", line 198 in _run_module_as_main
Fatal Python error: Aborted

Thread 0x00007fc1b4c80280 (most recent call first):
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/test__xxsubinterpreters.py", line 80 in clean_up_interpreters
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/test__xxsubinterpreters.py", line 88 in tearDown
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/case.py", line 594 in _callTearDown
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/case.py", line 637 in run
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/case.py", line 690 in __call__
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/runner.py", line 240 in run
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1115 in _run_suite
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1241 in run_unittest
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 294 in _test_module
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 330 in _runtest_inner2
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 373 in _runtest_inner
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 248 in _runtest
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 278 in runtest
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 365 in rerun_failed_tests
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 783 in _main
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 738 in main
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 802 in main
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/__main__.py", line 2 in <module>
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/runpy.py", line 88 in _run_code
  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/runpy.py", line 198 in _run_module_as_main

Extension modules: _testcapi, _xxsubinterpreters (total: 2)
Aborted
make: *** [Makefile:2009: buildbottest] Error 134

Cannot open file '/root/buildarea/3.12.angelico-debian-amd64/build/test-results.xml' for upload

pythongh-89886: Properly quote Autoconf macro arguments

80794c7

Autoconf 2.70 macros are picky about argument quotation.

erlend-aasland requested a review from corona10 as a code owner May 29, 2023 15:44

erlend-aasland requested review from gpshead and zware May 29, 2023 15:44

bedevere-bot added the awaiting core review label May 29, 2023

bedevere-bot mentioned this pull request May 29, 2023

Improve and simplify configure.ac checks #89886

Closed

erlend-aasland added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels May 29, 2023

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 29, 2023

erlend-aasland added the needs backport to 3.12 bug and security fixes label May 29, 2023

arhadthedev reviewed May 29, 2023

View reviewed changes

pyconfig.h.in Outdated Show resolved Hide resolved

zware reviewed May 30, 2023

View reviewed changes

pyconfig.h.in Outdated Show resolved Hide resolved

configure.ac Show resolved Hide resolved

gpshead reviewed May 30, 2023

View reviewed changes

configure.ac Outdated Show resolved Hide resolved

erlend-aasland added 4 commits May 30, 2023 20:56

Pull in main

8733c05

Reduce configure diff

4d43205

Revert backtick change

3deb15b

Fix spurious undef

68bc05e

erlend-aasland added 2 commits May 30, 2023 22:41

Fix dirfd

d4e92d6

regen configure

36e8b5b

zware approved these changes May 30, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels May 30, 2023

gpshead approved these changes May 30, 2023

View reviewed changes

erlend-aasland enabled auto-merge (squash) May 30, 2023 20:52

erlend-aasland merged commit 2ea34cf into python:main May 30, 2023

bedevere-bot removed the awaiting merge label May 30, 2023

miss-islington assigned erlend-aasland May 30, 2023

erlend-aasland deleted the autoconf/macro-audit branch May 30, 2023 21:19

bedevere-bot removed the needs backport to 3.12 bug and security fixes label May 30, 2023

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request May 30, 2023

[3.12] pythongh-89886: Properly quote Autoconf macro arguments (pytho…

f8f2982

…n#105062) Autoconf 2.70 macros are picky about argument quotation.

erlend-aasland added a commit that referenced this pull request May 30, 2023

[3.12] gh-89886: Properly quote Autoconf macro arguments (#105062) (#…

af7b55d

…105118) Autoconf 2.70 macros are picky about argument quotation.

This was referenced Jun 1, 2023

GH-89886: Bump autoconf to version 2.71 #104925

Merged

3.12 backport gh 105236 #105358

Closed

Osyotr mentioned this pull request Aug 20, 2023

[python3] Build error microsoft/vcpkg#33068

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-89886: Properly quote Autoconf macro arguments #105062

gh-89886: Properly quote Autoconf macro arguments #105062

erlend-aasland commented May 29, 2023 •

edited by bedevere-bot

Loading

bedevere-bot commented May 29, 2023

erlend-aasland commented May 29, 2023

erlend-aasland commented May 30, 2023

erlend-aasland commented May 30, 2023

gpshead left a comment

miss-islington commented May 30, 2023

miss-islington commented May 30, 2023

bedevere-bot commented May 30, 2023

bedevere-bot commented May 31, 2023

gh-89886: Properly quote Autoconf macro arguments #105062

gh-89886: Properly quote Autoconf macro arguments #105062

Conversation

erlend-aasland commented May 29, 2023 • edited by bedevere-bot Loading

bedevere-bot commented May 29, 2023

erlend-aasland commented May 29, 2023

erlend-aasland commented May 30, 2023

erlend-aasland commented May 30, 2023

gpshead left a comment

Choose a reason for hiding this comment

miss-islington commented May 30, 2023

miss-islington commented May 30, 2023

bedevere-bot commented May 30, 2023

bedevere-bot commented May 31, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

erlend-aasland commented May 29, 2023 •

edited by bedevere-bot

Loading