Skip to content

[3.12] gh-106584: Fix exit code for unittest in Python 3.12 (GH-106588) #109725

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 22, 2023

(cherry picked from commit 8fc0713)

Co-authored-by: EliseevEgor egor.eliseev@jetbrains.com
Co-authored-by: sunmy2019 59365878+sunmy2019@users.noreply.github.com
Co-authored-by: Nikita Sobolev mail@sobolevn.me

…106588)

(cherry picked from commit 8fc0713)

Co-authored-by: EliseevEgor <egor.eliseev@jetbrains.com>
Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@ambv
Copy link
Contributor

ambv commented Sep 22, 2023

This is a bug in 3.12.0, the fix should land for 3.12.1.

@Yhg1s Yhg1s merged commit 551aa6a into python:3.12 Oct 2, 2023
@miss-islington miss-islington deleted the backport-8fc0713-3.12 branch October 2, 2023 15:18
@sodul
Copy link

sodul commented Dec 12, 2023

@miss-islington, @ambv I suspect this change is breaking green on skipped tests: CleanCut/green#277

Green is tracking test duration by setting a time when startTest is called then calculates the duration in stopTest, unfortunately the changes here are now skipping startTest but not stopTest, if I read the changes correctly.

I will work with the green maintainer to update green to be compatible. There is no issue if no tests are skipped.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants