Skip to content

gh-111253: Fix socketmodule.c not checking for errors when initializing #111254

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2023
Merged

gh-111253: Fix socketmodule.c not checking for errors when initializing #111254

merged 2 commits into from
Oct 25, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 24, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 24, 2023
Closed
@erlend-aasland erlend-aasland enabled auto-merge (squash) October 25, 2023 06:44
@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 25, 2023
@erlend-aasland erlend-aasland merged commit 3052c09 into python:main Oct 25, 2023
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Sorry, @sobolevn and @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3052c098ca2779c2d9ab9800dabe66d0efa01794 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 25, 2023
@sobolevn @miss-islington
pythongh-111253: Fix error checking in _socket module init (pythonGH-…
92cc30d 
…111254)

(cherry picked from commit 3052c09)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Oct 25, 2023

GH-111299 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 25, 2023
vstinner pushed a commit that referenced this pull request Nov 1, 2023
@miss-islington @sobolevn
[3.12] gh-111253: Fix error checking in _socket module init (GH-111254)…
99f0dd8 
… (#111299)

gh-111253: Fix error checking in _socket module init (GH-111254)
(cherry picked from commit 3052c09)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sobolevn @aisk
pythongh-111253: Fix error checking in _socket module init (python#11…
2b69e40 
…1254)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn @Glyphack
pythongh-111253: Fix error checking in _socket module init (python#11…
e146dd9 
…1254)
@ZeroIntensity ZeroIntensity removed the needs backport to 3.11 only security fixes label Feb 17, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees

@erlend-aasland erlend-aasland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolevn @serhiy-storchaka @erlend-aasland @ZeroIntensity