Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

GH-115978: Disable *readv() and *writev() on WASI #116228

Merged
merged 3 commits into from
Mar 2, 2024
Merged

GH-115978: Disable *readv() and *writev() on WASI #116228

merged 3 commits into from
Mar 2, 2024

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Mar 1, 2024 •
edited by bedevere-app bot
Loading

Wasmtime doesn't implement them in a way to pass test_posix (bytecodealliance/wasmtime#7830).

This fix allows running under WASI 0.2 primitives for wasmtime.

@brettcannon
pythonGH-115978: Disable *readv() and *writev() on WASI
6694d23 
Wasmtime doesn't implement them in a way to pass test_posix (bytecodealliance/wasmtime#7830).

This fix allows running under WASI 0.2 primitives for wasmtime.
@brettcannon brettcannon self-assigned this Mar 1, 2024
@bedevere-app bedevere-app bot mentioned this pull request Mar 1, 2024
Closed
@brettcannon brettcannon added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Mar 1, 2024
@brettcannon
Copy link
Member Author

!buildbot wasi

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @brettcannon for commit 6694d23 🤖

The command will test the builders whose names match following regular expression: wasi

The builders matched are:

  • wasm32-wasi Non-Debug PR
  • wasm32 WASI 8Core PR
  • wasm32-wasi PR

@brettcannon
Copy link
Member Author

!buildbot wasi

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @brettcannon for commit 8dd3736 🤖

The command will test the builders whose names match following regular expression: wasi

The builders matched are:

  • wasm32-wasi Non-Debug PR
  • wasm32 WASI 8Core PR
  • wasm32-wasi PR

@brettcannon
Copy link
Member Author

!buildbot wasi

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @brettcannon for commit bdd3952 🤖

The command will test the builders whose names match following regular expression: wasi

The builders matched are:

  • wasm32-wasi Non-Debug PR
  • wasm32 WASI 8Core PR
  • wasm32-wasi PR

@brettcannon brettcannon merged commit 5dc8c84 into python:main Mar 2, 2024
41 checks passed
@brettcannon brettcannon deleted the issue115978-readv branch March 2, 2024 00:52
@miss-islington-app
Copy link

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 2, 2024
@brettcannon @miss-islington
pythonGH-115978: Disable *readv() and *writev() on WASI (pythonGH…
d561b05 
…-116228)

Wasmtime doesn't implement these functions in a way to pass test_posix (bytecodealliance/wasmtime#7830).
(cherry picked from commit 5dc8c84)

Co-authored-by: Brett Cannon <brett@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Mar 2, 2024

GH-116231 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 2, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 2, 2024
@brettcannon @miss-islington
pythonGH-115978: Disable *readv() and *writev() on WASI (pythonGH…
8c78c7c 
…-116228)

Wasmtime doesn't implement these functions in a way to pass test_posix (bytecodealliance/wasmtime#7830).
(cherry picked from commit 5dc8c84)

Co-authored-by: Brett Cannon <brett@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Mar 2, 2024

GH-116232 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Mar 2, 2024
brettcannon added a commit that referenced this pull request Mar 2, 2024
@miss-islington @brettcannon
[3.12] GH-115978: Disable *readv() and *writev() on WASI (GH-116228…
25b2159 
…) (GH-116231)

GH-115978: Disable `*readv()` and `*writev()` on WASI (GH-116228)

Wasmtime doesn't implement these functions in a way to pass test_posix (bytecodealliance/wasmtime#7830).
(cherry picked from commit 5dc8c84)

Co-authored-by: Brett Cannon <brett@python.org>
brettcannon added a commit that referenced this pull request Mar 2, 2024
@miss-islington @brettcannon
[3.11] GH-115978: Disable *readv() and *writev() on WASI (GH-116228…
862775b 
…) (GH-116232)

GH-115978: Disable `*readv()` and `*writev()` on WASI (GH-116228)

Wasmtime doesn't implement these functions in a way to pass test_posix (bytecodealliance/wasmtime#7830).
(cherry picked from commit 5dc8c84)

Co-authored-by: Brett Cannon <brett@python.org>
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@brettcannon @woodruffw
pythonGH-115978: Disable *readv() and *writev() on WASI (pythonGH…
2a86872 
…-116228)

Wasmtime doesn't implement these functions in a way to pass test_posix (bytecodealliance/wasmtime#7830).
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@brettcannon @adorilson
pythonGH-115978: Disable *readv() and *writev() on WASI (pythonGH…
377502c 
…-116228)

Wasmtime doesn't implement these functions in a way to pass test_posix (bytecodealliance/wasmtime#7830).
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@brettcannon @diegorusso
pythonGH-115978: Disable *readv() and *writev() on WASI (pythonGH…
2bb2b00 
…-116228)

Wasmtime doesn't implement these functions in a way to pass test_posix (bytecodealliance/wasmtime#7830).
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@brettcannon brettcannon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettcannon @bedevere-bot