Skip to content

gh-94673: Fix compiler warning in typeobject.c #117980

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 17, 2024

static_builtin_index_is_set() is only used in asserts; inline it to avoid compiler warnings.

static_builtin_index_is_set() is only used in asserts; inline it to avoid compiler warnings.
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. I have one suggestion for handling it a different way, which preserves the intention of the original code.

@erlend-aasland erlend-aasland enabled auto-merge (squash) April 17, 2024 17:28
@erlend-aasland erlend-aasland merged commit 353ea0b into python:main Apr 17, 2024
@erlend-aasland erlend-aasland deleted the fix-warning branch April 17, 2024 17:57
@ericsnowcurrently
Copy link
Member

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants