Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

gh-117398: Statically Allocate the Datetime C-API #119472

Merged
merged 6 commits into from
May 23, 2024
Merged

gh-117398: Statically Allocate the Datetime C-API #119472

merged 6 commits into from
May 23, 2024

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented May 23, 2024 •
edited by bedevere-app bot
Loading

This helps us support use in isolated subinterpreters.

@bedevere-app bedevere-app bot mentioned this pull request May 23, 2024
Closed
@ericsnowcurrently
Copy link
Member Author

@ncoghlan, this should alleviate some/all of the crash concerns with the datetime C-API.

@encukou encukou merged commit b30d30c into python:main May 23, 2024
36 checks passed
@ericsnowcurrently ericsnowcurrently deleted the datetime-capi branch May 23, 2024 19:16
@erlend-aasland
Copy link
Contributor

Thanks!

@ericsnowcurrently ericsnowcurrently added the needs backport to 3.13 bugs and security fixes label May 28, 2024
@miss-islington-app
Copy link

Thanks @ericsnowcurrently for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @ericsnowcurrently and @encukou, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b30d30c747df2bf9f1614df8e76db2ffdb24fcd8 3.13

@ericsnowcurrently ericsnowcurrently mentioned this pull request May 28, 2024
Merged
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request May 28, 2024
@ericsnowcurrently
pythongh-117398: Statically Allocate the Datetime C-API (pythonGH-119472
b263387 
)
@bedevere-app
Copy link

bedevere-app bot commented May 28, 2024

GH-119641 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 28, 2024
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request May 28, 2024
@ericsnowcurrently
pythongh-117398: Statically Allocate the Datetime C-API (pythonGH-119472
9c62e61 
)
ericsnowcurrently added a commit that referenced this pull request May 28, 2024
@ericsnowcurrently
[3.13] gh-117398: Statically Allocate the Datetime C-API (GH-119472) (g…
12a580b 
…h-119641)

This is a backport of 3 commits that go together.

(cherry picked from commit a895756)
(cherry picked from commit b30d30c)
(cherry picked from commit a89fc26)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@ericsnowcurrently @estyxx
pythongh-117398: Statically Allocate the Datetime C-API (pythonGH-119472
8affc4c 
)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@encukou encukou Awaiting requested review from encukou

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees

@encukou encukou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericsnowcurrently @erlend-aasland @encukou