-
-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
gh-121832: Skip subinterpreter static type check on iOS to restore test suite. #122150
Conversation
!buildbot iOS |
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit e92cada 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @freakboy3742 for unblocking this.
Thanks @freakboy3742 for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…ore test suite. (pythonGH-122150) (cherry picked from commit 1bcc9eb) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
GH-122159 is a backport of this pull request to the 3.13 branch. |
… (pythonGH-122340) Revert test skip introduced by pythonGH-122150. (cherry picked from commit 863a92f) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
The CPython test suite will crash if you run any test that creates a subinterpreter after running the
test_type_cache
test.This bug affects all platforms; but iOS is the only platform that reliably hits the bug as part of test suite execution, as it is the only platform that runs the test suite in a single process.
test_types
is the only test that creates a subinterpreter aftertest_type_cache
. This PR skips the subinterpreter slot tests that are part oftest_types
on iOS as a temporary measure so that we can observe other failures that might be occurring in iOS.When a final fix for #121832 is in place, this test skip can be removed.
--with-pydebug
enabled #121832