-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
gh-126366: Make native generators thread safe #126371
base: main
Are you sure you want to change the base?
Conversation
cc @colesbury |
I will try to take a look at today :) |
list.__init__
Closing in favor of #120327 |
Wait I closed my PR in favour of yours... 😆 @ZeroIntensity |
Ah! I'll reopen this and list you as a co-author if yours has merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a warning:
Check warning on line 129 in Python/ceval_macros.h
‘gen_frame’ may be used uninitialized in this function [-Wmaybe-uninitialized]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall approach LGTM. I'm feeling more confortable with more critical sections :-)
|
Co-authored-by: Ken Jin kenjin@python.org
ChainMap
of aCounter
in threads #126366