Skip to content

gh-133545: Also quote arguments containing &<>^| on Windows #134544

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jhohm
Copy link
Contributor

@jhohm jhohm commented May 22, 2025

In addition to space, tab, and empty string, quote arguments containing &<>^| on Windows.

Resolves #133545.

@jhohm jhohm changed the title gh-133545: Also quote arguments containing :&<>^| on Windows gh-133545: Also quote arguments containing &<>^| on Windows May 22, 2025
@gpshead gpshead requested a review from zooba May 23, 2025 22:07
@gpshead
Copy link
Member

gpshead commented May 23, 2025

looping in @zooba for windows specific experience as it behaves differently than others perhaps do. could this break real use cases that we just lack coverage for when launching processes?

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subprocess.Popen doesn't properly escape < or > for windows batch files
2 participants