gh-130655: add tests for dgettext #134594
Open
+36
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
reviewed
May 23, 2025
Lib/test/test_gettext.py
Outdated
| return mofile | ||
|
|
||
| def test_dgettext_found_translation(self): | ||
| """Test dgettext finds translation in specified domain.""" |
There was a problem hiding this comment.
Avoid using docstrings for test_* methods as it will be shown upon failure.
picnixz
reviewed
May 23, 2025
Lib/test/test_gettext.py
Outdated
|
|
||
| def setUp(self): | ||
| """Set up a specific test domain and environment for dgettext tests.""" | ||
| self.localedir = tempfile.mkdtemp() |
There was a problem hiding this comment.
Instead of using mkdtemp which would create something inside /tmp, use test.support.temp_dir (I think, check the name) which creates something inside the build folder (it's easier to cleanup)
picnixz
reviewed
May 23, 2025
Lib/test/test_gettext.py
Outdated
| def setUp(self): | ||
| """Set up a specific test domain and environment for dgettext tests.""" | ||
| self.localedir = tempfile.mkdtemp() | ||
| self.addCleanup(shutil.rmtree, self.localedir) |
There was a problem hiding this comment.
Prefer using os_helper.rmtree over shutil.rmtree
alex-semenyuk
force-pushed
the
add_dgettext_tests
branch
from
ecaa9d1 to
c4fb7ac
Compare
Comment on lines
+965
to
+972
| def test_dgettext_non_existent_domain(self): | ||
| result = gettext.dgettext('nonexistent_domain', 'test message') | ||
| self.assertEqual(result, 'test message') | ||
|
|
||
| def test_dgettext_empty_domain(self): | ||
| result = gettext.dgettext('', 'test message') | ||
| expected = gettext.gettext('test message') | ||
| self.assertEqual(result, expected) |
There was a problem hiding this comment.
This could just be a for loop combining these cases.
picnixz
changed the title
picnixz
added
needs backport to 3.13
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add tests for dgettext
dgettext#134593gettext#130655