gh-109934: notify cancelled futures on thread pool shutdown #134618
+53
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `ThreadPoolExecutor` shuts down it cancels any pending futures, however at present it doesn't notify waiters. Thus their state stays as `CANCELLED` instead of `CANCELLED_AND_NOTIFIED` and any waiters are not awakened. Call `set_running_or_notify_cancel` on the cancelled futures to fix this.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
ThreadPoolExecutorshuts down it cancels any pending futures, however at present it doesn't notify waiters. Thus their state stays asCANCELLEDinstead ofCANCELLED_AND_NOTIFIEDand any waiters are not awakened.Call
set_running_or_notify_cancelon the cancelled futures to fix this.