Skip to content

bpo-45723: Prepare support for autoconf 2.71 (GH-29441) #29441

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2021
Merged

bpo-45723: Prepare support for autoconf 2.71 (GH-29441) #29441

merged 1 commit into from
Nov 8, 2021

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 6, 2021 •
edited by bedevere-bot
Loading

AC_PROG_EGREP should be checked explicitly.

AC_CONFIG_HEADER -> AC_CONFIG_HEADERS

AC_USE_SYSTEM_EXTENSIONS must be defined before first use of AC_LINK
or AC_COMPILE macros.

STDC_HEADERS and AC_HEADER_TIME are obsolete.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue45723

@tiran tiran force-pushed the bpo-45723-prep271 branch from c4fe80a to fa14a14 Compare November 7, 2021 09:24
@tiran tiran added the skip news label Nov 7, 2021
@tiran tiran marked this pull request as ready for review November 7, 2021 09:34
@tiran tiran requested a review from rhettinger as a code owner November 7, 2021 09:34
@tiran tiran force-pushed the bpo-45723-prep271 branch from fa14a14 to 2b2a10e Compare November 7, 2021 10:18
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 7, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit 2b2a10ebcb4216c271248e2191c64f29a7a68912 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 7, 2021
@tiran tiran force-pushed the bpo-45723-prep271 branch from 2b2a10e to 2ffa2cb Compare November 8, 2021 07:17
@tiran tiran requested a review from erlend-aasland November 8, 2021 12:08
@tiran
Copy link
Member Author

tiran commented Nov 8, 2021

All changes are based on the output of 2.71's autoupdate tool.

erlend-aasland
erlend-aasland reviewed Nov 8, 2021
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look and left some comments.

@tiran tiran force-pushed the bpo-45723-prep271 branch from 2ffa2cb to c224b32 Compare November 8, 2021 12:50
@tiran
Copy link
Member Author

tiran commented Nov 8, 2021

autoconf 2.71 has deprecated the macro:

configure.ac:660: warning: The macro `AC_PROG_CC_C99' is obsolete.
configure.ac:660: You should run autoupdate.

@erlend-aasland
Copy link
Contributor

autoconf 2.71 has deprecated the macro:

configure.ac:660: warning: The macro `AC_PROG_CC_C99' is obsolete.
configure.ac:660: You should run autoupdate.

Oh, well 😆

@tiran
Copy link
Member Author

tiran commented Nov 8, 2021

In autoconf 2.71, AC_PROG_CC_C99 is an alias for AC_PROG_CC

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Nov 8, 2021 •
edited
Loading

In autoconf 2.71, AC_PROG_CC_C99 is an alias for AC_PROG_CC

It seems that we can use AC_PROG_CC and check ac_cv_prog_cc_c99:

Otherwise, if ac_cv_prog_cc_c99 is set to any value other than ‘no’
(including the empty string), then CC can compile code as standard
C 1999, and this mode has been enabled

@erlend-aasland
Copy link
Contributor

BTW, we need to make sure we set CFLAGS before calling AC_PROG_CC, so we don't accidentally default to -g -O2.

@tiran
Copy link
Member Author

tiran commented Nov 8, 2021

In autoconf 2.71, AC_PROG_CC_C99 is an alias for AC_PROG_CC

It seems that we can use AC_PROG_CC and check ac_cv_prog_cc_c99:

Otherwise, if ac_cv_prog_cc_c99 is set to any value other than ‘no’
(including the empty string), then CC can compile code as standard
C 1999, and this mode has been enabled

autoconf 2.71 no longer defines the variable ac_cv_prog_cc_c99. autoconf 2.69 only defines it for AC_PROG_CC_STDC.

erlend-aasland
erlend-aasland approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think one NEWS entry is enough ;)

@tiran
bpo-45723: Prepare support for autoconf 2.71
6a08338 
``AC_PROG_EGREP`` should be checked explicitly.

``AC_CONFIG_HEADER`` -> ``AC_CONFIG_HEADERS``

``AC_USE_SYSTEM_EXTENSIONS`` must be defined before first use of ``AC_LINK``
or ``AC_COMPILE`` macros.

``STDC_HEADERS`` and ``AC_HEADER_TIME`` are obsolete.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran tiran force-pushed the bpo-45723-prep271 branch from f8bfcf8 to 6a08338 Compare November 8, 2021 17:59
@tiran
Copy link
Member Author

tiran commented Nov 8, 2021

LGTM, but I think one NEWS entry is enough ;)

Oops :)

I have removed the second entry and rebased the PR.

@tiran tiran changed the title bpo-45723: Prepare support for autoconf 2.71 bpo-45723: Prepare support for autoconf 2.71 (GH-29441) Nov 8, 2021
@tiran tiran merged commit cbab997 into python:main Nov 8, 2021
@tiran tiran deleted the bpo-45723-prep271 branch November 8, 2021 18:31
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@tiran @remykarem
bpo-45723: Prepare support for autoconf 2.71 (pythonGH-29441)
dc91e43
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
@tiran @remykarem
bpo-45723: Prepare support for autoconf 2.71 (pythonGH-29441)
2ab74a4
@tiran tiran mentioned this pull request Apr 22, 2022
Closed
@mattip mattip mentioned this pull request Nov 23, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiran @bedevere-bot @erlend-aasland @the-knights-who-say-ni