Skip to content

bpo-33028: Correctly document class instead of function #32016

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2022
Merged

bpo-33028: Correctly document class instead of function #32016

merged 1 commit into from
Mar 23, 2022

Conversation

slateny
Copy link
Contributor

@slateny slateny commented Mar 20, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Mar 20, 2022
ezio-melotti
ezio-melotti approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM. The issue also mentions the name attribute and the cleanup method that could be documented separately, but even as they are documented now is fine IMHO.

@iritkatriel iritkatriel added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Mar 23, 2022
@iritkatriel iritkatriel merged commit 624e398 into python:main Mar 23, 2022
@miss-islington
Copy link
Contributor

Thanks @slateny for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @slateny and @iritkatriel, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 624e3986fbf8467772e4863b7ec004e65adff619 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 23, 2022
@bedevere-bot
Copy link

GH-32077 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 23, 2022
@slateny @miss-islington
Correctly document class instead of function (pythonGH-32016)
2451705 
(cherry picked from commit 624e398)

Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
iritkatriel pushed a commit that referenced this pull request Mar 23, 2022
@slateny @iritkatriel
Correctly document class instead of function (GH-32016)
b8b2c1e 
(cherry picked from commit 624e398)
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Mar 23, 2022
@bedevere-bot
Copy link

GH-32078 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Mar 23, 2022
@miss-islington @slateny
Correctly document class instead of function (GH-32016)
4298114 
(cherry picked from commit 624e398)

Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
@slateny slateny deleted the s/tempfile branch April 26, 2022 05:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ezio-melotti ezio-melotti ezio-melotti approved these changes

Assignees

@iritkatriel iritkatriel

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@slateny @miss-islington @bedevere-bot @ezio-melotti @iritkatriel @the-knights-who-say-ni