-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-80856: doc: reveal doctest directives #92318
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of whitespace inconsistencies, but otherwise LGTM.
Thanks @sorcio for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
* Doc: Reveal doctest directives. * Fix whitespace. Co-authored-by: Julien Palard <julien@palard.fr> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> (cherry picked from commit 7b024e3) Co-authored-by: Davide Rizzo <sorcio@gmail.com>
GH-92493 is a backport of this pull request to the 3.11 branch. |
GH-92494 is a backport of this pull request to the 3.10 branch. |
* Doc: Reveal doctest directives. * Fix whitespace. Co-authored-by: Julien Palard <julien@palard.fr> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> (cherry picked from commit 7b024e3) Co-authored-by: Davide Rizzo <sorcio@gmail.com>
Beware @sorcio, this "breaks" the minimum version of sphinx listed in Docs/conf.py: Line 48 in 859250c
The :no-trim-doctest-flags: was added in sphinx 3.2, so you need to bump to Bumping needs-sphinx to 3.2 were not OK one year ago, but it may be OK now, I really don't know. Let's ask to @asottile @doko42. The only thing I see is that one year ago Debian stable were shipping |
Hey @JulienPalard, thanks for the heads up! I'll wait for their responses and patch things up as needed. I hadn't noticed that you previously suggested compatibility with Sphinx 2 would be maintained for "a few more releases", otherwise I wouldn't have pushed this forward. If the limitation to stay with Sphinx < 3 is confirmed, would it apply to 3.10 only or to main as well? This has been a bug in the published doc for a while. In the worst case, I'd consider adding a backport of the doctest directive. I think the questions are:
|
I can't speak for debian but I've disabled the docs builds entirely for the pythons I distribute for deadsnakes (it ended up being 90%+ of the maintenance work so I stopped trying) so bumping the version there is no longer a concern for me! 👍 |
Issue: gh-80856
This is literally just the change from #23620 cherry-picked to apply on top of main again.
Since docs now build on Sphinx 4.5.0,
:no-trim-doctest-flags:
is now supported and this change can be applied.