Skip to content

Auto-cancel old builds when new commit pushed to branch #98009

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2022
Merged

Auto-cancel old builds when new commit pushed to branch #98009

merged 3 commits into from
Oct 8, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 7, 2022

Let's use GitHub Actions' concurrency to cancel outdated runs.

So if you push more than once to a given branch, it auto-cancels runs for older commits to make way for the newest commit to run.

This will help when there's a large backlog of builds and we're hitting limits.

Docs:

Is an issue needed?

@ambv ambv added the skip issue label Oct 7, 2022
@hugovk @ezio-melotti
Add a fallback
ee74a85 
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
ambv
ambv reviewed Oct 7, 2022
View reviewed changes
ezio-melotti
ezio-melotti reviewed Oct 8, 2022
View reviewed changes
@ezio-melotti ezio-melotti self-assigned this Oct 8, 2022
@ezio-melotti
Copy link
Member

I'm going to merge this and see what happens. If everything works well I will backport it.

@ezio-melotti ezio-melotti merged commit 75751f4 into python:main Oct 8, 2022
@ezio-melotti
Copy link
Member

This seems to be working well:
image

@ezio-melotti ezio-melotti added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 8, 2022
@miss-islington
Copy link
Contributor

Thanks @hugovk for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @hugovk for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @hugovk and @ezio-melotti, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 75751f4aa5d70f65856645a9128fd42d92d6692c 3.11

@miss-islington
Copy link
Contributor

Sorry @hugovk and @ezio-melotti, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 75751f4aa5d70f65856645a9128fd42d92d6692c 3.10

@ezio-melotti
Copy link
Member

(If we backport #92999 the conflict should go away and make the workflow files more consistent between branches, so I'm waiting for that before backporting this.)

@hugovk hugovk deleted the cancel-old-builds branch October 9, 2022 06:24
carljm added a commit to carljm/cpython that referenced this pull request Oct 9, 2022
@carljm
Merge branch 'main' into typewatch
71d48c1 
* main:
  Minor edits to the Descriptor HowTo Guide (pythonGH-24901)
  Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)
  pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers  (python#98089)
  Auto-cancel old builds when new commit pushed to branch (python#98009)
  pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)
carljm added a commit to carljm/cpython that referenced this pull request Oct 9, 2022
@carljm
Merge branch 'main' into urllibnonet
132c32e 
* main: (5519 commits)
  Minor edits to the Descriptor HowTo Guide (pythonGH-24901)
  Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)
  pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers  (python#98089)
  Auto-cancel old builds when new commit pushed to branch (python#98009)
  pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)
  pythongh-68686: Retire eptag ptag scripts (python#98064)
  pythongh-97922: Run the GC only on eval breaker (python#97920)
  GitHub Workflows security hardening (python#96492)
  Add `@ezio-melotti` as codeowner for `.github/`. (python#98079)
  pythongh-97913 Docs: Add walrus operator to the index (python#97921)
  [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914)
  pythongh-97822: Fix http.server documentation reference to test() function (python#98027)
  pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055)
  pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024)
  pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184)
  pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058)
  pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060)
  pythongh-57179: Add note on symlinks for os.walk (python#94799)
  pythongh-94808: Fix regex on exotic platforms (python#98036)
  pythongh-90085: Remove vestigial -t and -c timeit options (python#94941)
  ...
@ezio-melotti ezio-melotti added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 10, 2022
@ezio-melotti ezio-melotti added the needs backport to 3.11 only security fixes label Oct 10, 2022
@miss-islington
Copy link
Contributor

Thanks @hugovk for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @hugovk for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @hugovk and @ezio-melotti, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 75751f4aa5d70f65856645a9128fd42d92d6692c 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2022
@hugovk @miss-islington
Auto-cancel old builds when new commit pushed to branch (pythonGH-98009)
d25cac6 
* Auto-cancel old builds when new commit pushed to branch

* Add a fallback

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>

* Use the same group for all workflows.

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
(cherry picked from commit 75751f4)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-bot
Copy link

GH-98162 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 10, 2022
@bedevere-bot
Copy link

GH-98163 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 10, 2022
miss-islington added a commit that referenced this pull request Oct 10, 2022
@miss-islington @hugovk
Auto-cancel old builds when new commit pushed to branch (GH-98009)
9d44ca5 
* Auto-cancel old builds when new commit pushed to branch

* Add a fallback

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>

* Use the same group for all workflows.

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
(cherry picked from commit 75751f4)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
ezio-melotti added a commit that referenced this pull request Oct 10, 2022
@ezio-melotti @hugovk
[3.10] Auto-cancel old builds when new commit pushed to branch (GH-98009
428bd02 
) (#98163)

* Auto-cancel old builds when new commit pushed to branch

* Add a fallback

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>

* Use the same group for all workflows.

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
(cherry picked from commit 75751f4)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@ezio-melotti
Copy link
Member

Backported 🥳

mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@hugovk @ezio-melotti @mpage
Auto-cancel old builds when new commit pushed to branch (python#98009)
5723b53 
* Auto-cancel old builds when new commit pushed to branch

* Add a fallback

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>

* Use the same group for all workflows.

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ambv ambv ambv left review comments

@sobolevn sobolevn sobolevn left review comments

@ezio-melotti ezio-melotti ezio-melotti approved these changes

Assignees

@ezio-melotti ezio-melotti

Labels
skip issue skip news
Projects
Sprint 2024
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hugovk @ezio-melotti @miss-islington @bedevere-bot @ambv @sobolevn