Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixing flaky CI #18660

Open
JukkaL opened this issue Feb 11, 2025 · 5 comments
Open

Fixing flaky CI #18660

JukkaL opened this issue Feb 11, 2025 · 5 comments
Labels
priority-0-high topic-developer Issues relevant to mypy developers

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Feb 11, 2025

GitHub actions have been flaky recently. Often some jobs immediately fail. Example: https://github.com/python/mypy/actions/runs/13202245866/job/36856826752?pr=18630

I wonder if this is related to the recent switch to Linux ARM runners. Any ideas?

@JukkaL JukkaL added priority-0-high topic-developer Issues relevant to mypy developers labels Feb 11, 2025
@sterliakov
Copy link
Collaborator

It is related to ARM runners, see my report here (closed as duplicate of discussion, so a bit difficult to navigate) and follow the link to https://github.com/orgs/community/discussions/148648#discussioncomment-11866202. They propose using 22.04 version for now, but I don't see any confirmation in thread that it works.

@cdce8p
Copy link
Collaborator

cdce8p commented Feb 12, 2025

It is related to ARM runners

Yes, unfortunately they haven't been able to resolve it until know. The first reports of it are almost four weeks old at this point.

The latest I've read is that they suggest to try out the ubuntu-22.04-arm variants as @sterliakov mentioned. Probably because they've deployed a fix there first to see how it goes.

There are a few options now:

  1. Just revert back to ubuntu-latest for now. (Revert most of Use new Github actions ARM runners for tests #18483)
  2. Switch to ubuntu-22.04-arm and see how that goes.
  3. Keep the current ubuntu-24.04-arm runners and hope they fix the issue soon. Usually all that's needed is to restart the failing job as it's just the action/checkout step which failed. This also applies to https://github.com/mypyc/mypy_mypyc-wheels where we use the arm runners to speed up the aarch builds.
    Looking at the workflow runs would suggest that it has already become more stable in the last few days. https://github.com/mypyc/mypy_mypyc-wheels/actions

I personally hope they fix it soon for good in which case we don't have to do anything.

@JukkaL
Copy link
Collaborator Author

JukkaL commented Feb 12, 2025

Let's wait a few more weeks (until end of Feb), and if the situation doesn't improve, let's try switching to ubuntu-22.04-arm first, and if it doesn't help, we may want to revert to non-ARM runners. Reverting to 22.04 shouldn't have much concrete impact.

@cdce8p
Copy link
Collaborator

cdce8p commented Feb 14, 2025

I've seen multiple workflow runs fail the few days. Reportedly ubuntu-22.04-arm should be fixed. Opened #18676 to see how it looks. We can always switch back later.

JukkaL pushed a commit that referenced this issue Feb 14, 2025
The `actions/checkout` issue with the new Github arm runners is
reportedly fixed on `ubuntu-22.04-arm`. Let's try and see how it goes.
We can always switch back later when `ubuntu-24.04-arm` is fixed as
well.

Ref #18660
@sterliakov
Copy link
Collaborator

Just for the record, they now say in the linked discussion that the issue is resolved for 24.04 as well.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
priority-0-high topic-developer Issues relevant to mypy developers
Projects
None yet
Development

No branches or pull requests

3 participants