Skip to content

Factor out field_makers alongside dataclass_makers #11584

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 22, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion mypy/plugins/dataclasses.py
Original file line number Diff line number Diff line change
@@ -24,6 +24,11 @@
'dataclass',
'dataclasses.dataclass',
}
# The set of functions that generate dataclass fields.
field_makers: Final = {
'dataclasses.field',
}


SELF_TVAR_NAME: Final = "_DT"

@@ -490,7 +495,7 @@ def _collect_field_args(expr: Expression,
if (
isinstance(expr, CallExpr) and
isinstance(expr.callee, RefExpr) and
expr.callee.fullname == 'dataclasses.field'
expr.callee.fullname in field_makers
):
# field() only takes keyword arguments.
args = {}