Fix type object with type var default in union context #17991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Union type context wasn's handled previously, and it triggered false positives, but apparently only if a type object had type var defaults. Fixes #17942.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
svalentin
approved these changes
Oct 18, 2024
hauntsaninja
pushed a commit
to hauntsaninja/mypy
that referenced
this pull request
Oct 18, 2024
Union type context wasn't handled previously, and it triggered false positives, but apparently only if a type object had type var defaults. Fixes python#17942.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Union type context wasn't handled previously, and it triggered false positives, but apparently only if a type object had type var defaults.
Fixes #17942.