Skip to content

enable --pretty by default #19122

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

enable --pretty by default #19122

wants to merge 2 commits into from

Conversation

mkaraev
Copy link

@mkaraev mkaraev commented May 21, 2025

closes #19108

This comment has been minimized.

Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@wyattscarpenter
Copy link
Contributor

wyattscarpenter commented Jun 4, 2025

You have a large number of test failures here, presumably because a bunch of expected errors have switched to giving the pretty error messages now!

These will need to be resolved before this pull request can be accepted. There's some kind of flag to make pytest update all the tests, but I've never used it; I just know about it because on test failures it prints this little message: Update the test output using --update-data (implies -n0; you can additionally use the -k selector to update only specific tests. You should probably also give all of those changes a cursory manual review, as well, but I suppose that comes down to how confident you feel. (Especially review ones that actually test the pretty flag, to make sure the new way the flag works actually works.) I suppose another solution would be to give the no-pretty specification explicitly to all of these tests, although I see little reason why that would be preferable.

@mkaraev
Copy link
Author

mkaraev commented Jun 4, 2025

@wyattscarpenter okay, I will check how tests could be updated

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable --pretty by default
2 participants