Fix type extraction from isinstance checks
#19223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the underlying type
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: antidote (https://github.com/Finistere/antidote): 1.44x slower (63.3s -> 91.3s in single noisy sample)
ibis (https://github.com/ibis-project/ibis)
- ibis/formats/pandas.py:71: error: Incompatible types in assignment (expression has type "list[float]", variable has type "Series[Any] | Iterable[tuple[str, dtype[Any] | ExtensionDtype]]") [assignment]
- ibis/legacy/udf/vectorized.py:174: error: Argument 1 to "len" has incompatible type "float"; expected "Sized" [arg-type]
pandas (https://github.com/pandas-dev/pandas)
+ pandas/core/algorithms.py:219: error: Unused "type: ignore" comment [unused-ignore]
+ pandas/core/arrays/datetimes.py:334: error: Unused "type: ignore" comment [unused-ignore]
materialize (https://github.com/MaterializeInc/materialize): 1.06x slower (132.1s -> 139.8s in single noisy sample)
janus (https://github.com/aio-libs/janus): 7.79x slower (0.9s -> 6.8s in single noisy sample)
mypy (https://github.com/python/mypy): 1.07x slower (94.5s -> 101.3s in single noisy sample)
spark (https://github.com/apache/spark)
- python/pyspark/pandas/typedef/typehints.py:670: error: Incompatible types in assignment (expression has type "type[float64] | Any", variable has type "type[NameTypeHolder]") [assignment]
- python/pyspark/pandas/typedef/typehints.py:834: error: Incompatible types in assignment (expression has type "type[float64] | Any", variable has type "None") [assignment]
+ python/pyspark/pandas/typedef/typehints.py:834: error: Incompatible types in assignment (expression has type "type[Any] | Any", variable has type "None") [assignment]
- python/pyspark/pandas/typedef/typehints.py:847: error: Incompatible types in assignment (expression has type "type[float64] | Any", variable has type "None") [assignment]
+ python/pyspark/pandas/typedef/typehints.py:847: error: Incompatible types in assignment (expression has type "type[Any] | Any", variable has type "None") [assignment]
imagehash (https://github.com/JohannesBuchner/imagehash): 1.06x slower (79.2s -> 84.3s in single noisy sample)
discord.py (https://github.com/Rapptz/discord.py): 1.08x faster (299.0s -> 276.0s in single noisy sample)
|
|
Primer hits look correct, that's a few more false positives fixed. |
JukkaL
approved these changes
Jun 5, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19221. Instead of trying to use the first (maybe) overload item and erase it, just use the underlying type with Any-filled typevars