Fix type of conditional statement to Union and not Join. (#3487) #5041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
reviewed
May 14, 2018
| @@ -385,7 +385,7 @@ def lookup_field(name, obj): | |||
| attr = None | |||
|
|
|||
| [case testTernaryWithNone] | |||
| reveal_type(None if bool() else 0) # E: Revealed type is 'Union[builtins.int, builtins.None]' | |||
| reveal_type(None if bool() else 0) # E: Revealed type is 'Union[builtins.None, builtins.int]' | |||
There was a problem hiding this comment.
Could you please add few dedicated tests? (Probably not in this test but in check-unions)
JukkaL
added a commit
that referenced
this pull request
May 22, 2018
Use a join for type of a conditional expression unless the type context is a union type. A recent change (#5041) modified the type to always use a union, but this caused many problems in internal Dropbox repos that we aren't ready to fix yet.
msullivan
pushed a commit
that referenced
this pull request
May 24, 2018
Use a join for type of a conditional expression unless the type context is a union type. A recent change (#5041) modified the type to always use a union, but this caused many problems in internal Dropbox repos that we aren't ready to fix yet.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.