Mitigate a regression in the external context #6006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The AppVeyor failure is a flake Also this passes cleanly on our codebases. |
|
@ilevkivskyi Ah, I think that is likely related to whatever failures already observed in #5983. Sorry! |
JukkaL
approved these changes
Dec 5, 2018
|
@JukkaL Probably it makes sense to cherry-pick this one. |
|
Not sure we should cp this—we won’t have time to move our internal pins and
test it properly.
On Wed, Dec 5, 2018 at 7:20 AM Ivan Levkivskyi ***@***.***> wrote:
@JukkaL <https://github.com/JukkaL> Probably it makes sense to
cherry-pick this one.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#6006 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACwrMg2_oQ-l-egNegpN9HoNUY4-B_t0ks5u1-Q5gaJpZM4ZBPbV>
.
--
--Guido (mobile)
|
|
This is a fundamental enough change that we should test this internally before a release. |
|
Then let's leave it for the 0.660 release. The previous pin move took me
all afternoon.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigates #5738 by reverting heuristics for type variable return vs instance type outer context changed in #5699. Both versions are kind of unprincipled, but the old one seems to work better in real codebases.
This doesn't touch the core fixes in #5699
cc @euresti could you please double check this also fixes your
attr.Factoryuse cases?