Add support for future.utils.with_metaclass #7210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmatyping
approved these changes
Jul 14, 2019
Ah yeah, I missed the tests for |
|
So this is going to require stubs for |
|
For the purposes of mypy tests, you can probably put a basic stub in mypy/test-data somewhere with just what you need. |
|
There is also a merge conflict now. |
|
No worries. It’s a very simple PR. I’ve just about got the stubs ready for
typeshed, so I’ll be revisiting this soon.
…On Thu, Aug 8, 2019 at 10:44 AM Ivan Levkivskyi ***@***.***> wrote:
There is also a merge conflict now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7210?email_source=notifications&email_token=AAAPOE2SM3FKWTXDBY5IKN3QDRLQTA5CNFSM4IDRQPOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD34MG7I#issuecomment-519619453>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAPOE2REG6HDOQECYXHF43QDRLQTANCNFSM4IDRQPOA>
.
|
Same function signature and basic behavior as six.with_metaclass
chadrik
force-pushed
the
future_with_metaclass
branch
from
27b07de to
2721ae4
Compare
|
Added tests. This should be all ready to go! |
ilevkivskyi
approved these changes
Oct 11, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This util function has the same signature and basic behavior as
six.with_metaclass.Fixes #7193.