Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove __eq__ and __ne__ overrides for dataclasses and attrs #8642

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Remove __eq__ and __ne__ overrides for dataclasses and attrs #8642

merged 1 commit into from
Apr 8, 2020

Conversation

tkukushkin
Copy link
Contributor

Fixes #8638.

JukkaL
JukkaL approved these changes Apr 8, 2020
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Creating __eq__ and __ne__ methods seems to serve no useful purpose.

@JukkaL
Copy link
Collaborator

JukkaL commented Apr 8, 2020

The Travis failure is a flake.

@JukkaL JukkaL merged commit a6c3e07 into python:master Apr 8, 2020
@tkukushkin tkukushkin mentioned this pull request Apr 9, 2020
Merged
@tkukushkin tkukushkin deleted the fix-8638 branch April 9, 2020 10:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid definition of __eq__ on dataclasses
2 participants
@tkukushkin @JukkaL