Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix superclass for UnixDatagramServer and UnixStreamServer #11115

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

tungol
Copy link
Contributor

@tungol tungol commented Dec 7, 2023

related to #3968

This should be pretty minor as far as I can see; TCPServer and UDPServer are both subclasses of BaseServer. I couldn't find any prior discussion or clear reason why they weren't used in the first place here, so it's quite possible I missed something.

Copy link
Contributor

github-actions bot commented Dec 7, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit 1b66910 into python:main Dec 7, 2023
@tungol tungol deleted the socketserver branch December 7, 2023 10:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants