-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Setup renovate for updating dependencies #11565
Conversation
I use renovate over at typeshed-stats, FWIW, and I've been reasonably happy with it. Here's an example PR: |
IIRC someone does need to add it to the org, but the app can be installed with only perms for one repo. Maybe one day dependabot will get this... dependabot/dependabot-core#2483 (comment) |
I pushed some buttons but it doesn't seem like I have access to authorize the app here either; we'll probably have to ping Łukasz to do it. |
Well, let's decide amongst ourselves whether this is a solution we like before we ping him 😄 |
The PR now also configures renovate to update our pre-commit config file, and removes our existing checks that make sure our I looked into switching off pre-commit autoupdate PRs altogether, but it seems that's not possible (pre-commit-ci/issues#83). So it's possible we'll get PRs from both renovate and pre-commit on the first day of each quarter, if we go with this. I think we can live with that, though, personally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR sets up a renovate configuration file for updating dependencies. It is a competing PR to #11564.
The proposed configuration:
The advantages of renovate over dependabot are:
pyproject.toml
by defining a custom "manager" that uses a regex to grab the pyright version from ourpyproject.toml
file and check to see if it needs updates.The disadvantages of renovate over dependabot are:
python
organisation rather than just an admin for typeshed? (I am neither, so don't really know.)Fixes #11484
Closes #11491
Closes #11564