Add new fields to TracebackException, fix cause/context/lineno types #13231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinji
changed the title
kevinji
changed the title
kevinji
force-pushed
the
patch-1
branch
2 times, most recently
from
ba3497a to
225fc22
Compare
These are derived from the TracebackException docs: https://docs.python.org/3/library/traceback.html#traceback.TracebackException and the source code: https://github.com/python/cpython/blob/8b3cccf3f9508572d85b0044519f2bd5715dacad/Lib/traceback.py#L989
|
Diff from mypy_primer, showing the effect of this PR on open source code: werkzeug (https://github.com/pallets/werkzeug)
+ src/werkzeug/debug/tbtools.py:261: error: Incompatible types in assignment (expression has type "Optional[TracebackException]", variable has type "TracebackException") [assignment]
|
kevinji
added a commit
to kevinji/werkzeug
that referenced
this pull request
Dec 11, 2024
This preps for a typing fix in python/typeshed#13231 where `__cause__` and `__context__` can be None.
JelleZijlstra
approved these changes
Dec 23, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are derived from the TracebackException docs: https://docs.python.org/3/library/traceback.html#traceback.TracebackException
and the source code:
https://github.com/python/cpython/blob/8b3cccf3f9508572d85b0044519f2bd5715dacad/Lib/traceback.py#L989