-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add python-gnupg stubs #13465
base: main
Are you sure you want to change the base?
Add python-gnupg stubs #13465
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, notes below. Also:
- Please add a comment for each
Any
explaining the valid types. - Instance variables initialized in
__init__
should be added to all classes. - Default values should be the actual default values, not
...
(unless they are complex).
__author__: str = ... | ||
__date__: str = ... | ||
|
||
from typing import Protocol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be combined with the imports above.
logger: logging.Logger = ... | ||
fsencoding: str = ... | ||
|
||
UNSAFE: re.Pattern[Any] = ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering this is only defined on some platforms, I would just add gnupg.UNSAFE
to @tests/stubtest_allowlist.txt
.
UID_INDEX: int = ... | ||
FIELDS: list[str] = ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above.
FIELDS: list[str] = ... | ||
def __init__(self, gpg: GPG) -> None: ... | ||
def key(self, args: Any) -> None: ... | ||
sec: Any = ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sec: Any = ... | |
pub = key | |
sec = key |
Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
No description provided.