Contributed stubs for markdown package #4426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
requested changes
Aug 8, 2020
There was a problem hiding this comment.
Thanks! This is also missing init.pyi, which a) seems to cause mypy to not find these stubs, b) you'll want to import Markdown, markdown and markdownFromFile as per https://github.com/Python-Markdown/markdown/blob/370e17b3923d7d8f4709652bc24b695271a0210d/markdown/__init__.py#L38
Also CI says isort is unhappy
| class Markdown: | ||
| def __init__( | ||
| self, | ||
| extensions: Optional[Sequence[Union[str, Extension]]] = ..., |
There was a problem hiding this comment.
These should be marked as keyword-only
|
|
||
| def markdown( | ||
| text: Text, | ||
| extensions: Optional[Sequence[Union[str, Extension]]] = ..., |
There was a problem hiding this comment.
extensions and on should be keyword only
| tab_length: Optional[int] = ..., | ||
| ) -> Text: ... | ||
| def markdownFromFile( | ||
| input: Optional[Union[str, TextIO, BinaryIO]] = ..., |
There was a problem hiding this comment.
all of these should also be keyword only
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.