-
Notifications
You must be signed in to change notification settings - Fork 258
conformance: aliases_typealiastype: quote recursive aliases, and add … #1998
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but you'll also have to update the generated results.
@JelleZijlstra i followed the steps in the readme regarding updating the results, it led to crashes regarding python 3.11, i attempted to debug by using python 3.11 instead and lead to other crashes i included all the updates that were generated, please advise
|
8585788
to
07fae65
Compare
Yeah I think you need to have a 3.12 venv to run the main script, but have a 3.11 in the path in order to run pytype. I can try to run it later. |
This is caused by facebook/pyre-check#988 - pyre was broken by an upgrade of click. A new pyre version that pins the click version should be out soon; as a manual workaround, you can uninstall click-8.2.0 and install click-8.1.8. |
…an invalid case for unquoted
24f478f
to
8dd72b1
Compare
i can't update these results on my machine, perhaps someone else could assist here? |
conformant = "Pass" | ||
conformant = "Partial" | ||
notes = """ | ||
no error for `type(n1).label` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit: See above for comment about notes. Also, it's not clear what "no error for type(n1).label
" means here, so consider a better note.
conformant = "Pass" | ||
conformant = "Partial" | ||
notes = """ | ||
incorrectly allows undefined self reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit: Please make notes complete sentences starting with a capital letter and ending with a period (for consistency with all other notes). These appear in the conformance test results page when you mouse over each box in the report, so it's good for them to be consistent.
…an invalid case for unquoted