Skip to content

conformance: aliases_typealiastype: quote recursive aliases, and add … #1998

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KotlinIsland
Copy link

…an invalid case for unquoted

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but you'll also have to update the generated results.

@KotlinIsland
Copy link
Author

KotlinIsland commented May 13, 2025

@JelleZijlstra i followed the steps in the readme regarding updating the results, it led to crashes regarding python 3.11, i attempted to debug by using python 3.11 instead and lead to other crashes

i included all the updates that were generated, please advise

Successfully installed pyre-check-0.9.23
Running tests for pyre
Usage: pyre [OPTIONS] COMMAND [ARGS]...
Try 'pyre -h' for help.

Error: Invalid value for '--version': <VersionKind.NONE: 'none'> is not one of 'none', 'client', 'client_and_binary'.
Usage: pyre [OPTIONS] COMMAND [ARGS]...
Try 'pyre -h' for help.

Error: Invalid value for '--version': <VersionKind.CLIENT_AND_BINARY: 'client_and_binary'> is not one of 'none', 'client', 'client_and_binary'.

@KotlinIsland KotlinIsland force-pushed the main branch 2 times, most recently from 8585788 to 07fae65 Compare May 13, 2025 08:13
@JelleZijlstra
Copy link
Member

Yeah I think you need to have a 3.12 venv to run the main script, but have a 3.11 in the path in order to run pytype. I can try to run it later.

@rchen152
Copy link
Collaborator

@JelleZijlstra i followed the steps in the readme regarding updating the results, it led to crashes regarding python 3.11, i attempted to debug by using python 3.11 instead and lead to other crashes

i included all the updates that were generated, please advise

Successfully installed pyre-check-0.9.23
Running tests for pyre
Usage: pyre [OPTIONS] COMMAND [ARGS]...
Try 'pyre -h' for help.

Error: Invalid value for '--version': <VersionKind.NONE: 'none'> is not one of 'none', 'client', 'client_and_binary'.
Usage: pyre [OPTIONS] COMMAND [ARGS]...
Try 'pyre -h' for help.

Error: Invalid value for '--version': <VersionKind.CLIENT_AND_BINARY: 'client_and_binary'> is not one of 'none', 'client', 'client_and_binary'.

This is caused by facebook/pyre-check#988 - pyre was broken by an upgrade of click. A new pyre version that pins the click version should be out soon; as a manual workaround, you can uninstall click-8.2.0 and install click-8.1.8.

@KotlinIsland KotlinIsland force-pushed the main branch 2 times, most recently from 24f478f to 8dd72b1 Compare May 19, 2025 07:29
@KotlinIsland
Copy link
Author

OSError: [Errno 86] Bad CPU type in executable: '/Users/AMONGUS/projects/python-typing/conformance/.venv/bin/pyre.bin'

i can't update these results on my machine, perhaps someone else could assist here?

conformant = "Pass"
conformant = "Partial"
notes = """
no error for `type(n1).label`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: See above for comment about notes. Also, it's not clear what "no error for type(n1).label" means here, so consider a better note.

conformant = "Pass"
conformant = "Partial"
notes = """
incorrectly allows undefined self reference
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: Please make notes complete sentences starting with a capital letter and ending with a period (for consistency with all other notes). These appear in the conformance test results page when you mouse over each box in the report, so it's good for them to be consistent.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants