Skip to content

fix: Upgrade to PyTorch 2.0.1 Release Candidate + Other improvements #1857

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2023
Merged

fix: Upgrade to PyTorch 2.0.1 Release Candidate + Other improvements #1857

merged 1 commit into from
May 2, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Apr 25, 2023 •
edited
Loading

Description

  • Add support for --legacy flag in setup.py, to enable installation with PyTorch 1.13.1
  • Add in test cases previously disabled due to dependency issues
  • Improve documentation of READMEs across repository
  • Update cudnn version to 8.8, update TRT version to 8.6 across all files and READMEs
  • Update docker folder on release branch to use new build system with custom TRT, cudnn, CUDA, and Python versions
  • Update WORKSPACE files to use Torch 2.0.1 Release Candidate

Stacked with PR #1759

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Functionality + Testing Additions
  • Version Upgrades

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ - ] I have added tests to verify my fix or my feature
    • CI Testing
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive self-assigned this Apr 25, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: build system Issues re: Build system component: core Issues re: The core compiler component: fx component: runtime component: tests Issues re: Tests labels Apr 25, 2023
@github-actions github-actions bot requested a review from narendasan April 25, 2023 00:56
@gs-olive gs-olive removed the request for review from narendasan April 25, 2023 00:57
@gs-olive gs-olive added the WIP Work is in progress, pull request should not be merged yet label Apr 25, 2023
@github-actions github-actions bot requested a review from narendasan April 25, 2023 01:14
@gs-olive gs-olive removed component: tests Issues re: Tests component: core Issues re: The core compiler component: build system Issues re: Build system component: api [Python] Issues re: Python API component: runtime component: fx fx labels Apr 25, 2023
@gs-olive gs-olive removed the request for review from narendasan April 25, 2023 01:25
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: build system Issues re: Build system component: core Issues re: The core compiler component: fx component: runtime component: tests Issues re: Tests labels Apr 25, 2023
@gs-olive gs-olive removed component: tests Issues re: Tests component: core Issues re: The core compiler component: build system Issues re: Build system labels Apr 25, 2023
@github-actions github-actions bot added the component: tests Issues re: Tests label Apr 25, 2023
@gs-olive gs-olive removed component: tests Issues re: Tests component: core Issues re: The core compiler component: build system Issues re: Build system component: api [Python] Issues re: Python API component: runtime component: fx labels Apr 25, 2023
@gs-olive gs-olive force-pushed the release_verification branch from d5bd60e to 339675d Compare April 26, 2023 00:28
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: build system Issues re: Build system component: core Issues re: The core compiler component: fx component: runtime component: tests Issues re: Tests labels Apr 26, 2023
@gs-olive gs-olive changed the base branch from release/1.4 to stack_upgrade_1.4 April 26, 2023 00:29
@gs-olive gs-olive changed the title Do Not Merge: PyTorch 2.0.1 CI Testing fix: Upgrade to PyTorch 2.0.1 Release Candidate + Other improvements Apr 26, 2023
@gs-olive gs-olive marked this pull request as ready for review April 26, 2023 00:32
@gs-olive gs-olive requested review from narendasan and peri044 and removed request for narendasan April 26, 2023 00:32
gs-olive
gs-olive commented Apr 26, 2023
View reviewed changes
Copy link
Collaborator Author

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker updates were adapted from PR #1805, and customized to CUDA version 11.8

py/torch_tensorrt/fx/test/passes/test_fuse_permute_linear_trt.py
Comment on lines -57 to -61
# TODO: The following test has been disabled due to a bug in TRT 8.5.1.7
# with self.linear2. Issue : https://github.com/pytorch/TensorRT/issues/1444
@unittest.skip(
reason="test_multi_fuse_permute_linear has been disabled due to a bug in TRT 8.5.1.7 https://github.com/pytorch/TensorRT/issues/1444"
)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed test skip since TRT 8.5 is no longer in use

@gs-olive gs-olive removed the WIP Work is in progress, pull request should not be merged yet label Apr 26, 2023
@gs-olive gs-olive requested a review from narendasan April 26, 2023 00:36
@gs-olive gs-olive force-pushed the release_verification branch from 339675d to 17398a9 Compare April 26, 2023 22:08
@gs-olive
fix: Upgrade to PyTorch 2.0.1 + Other improvements
7673be2 
- Add support for `--legacy` flag in `setup.py`, to enable installation
with PyTorch 1.13.1
- Add in test cases previously disabled due to dependency issues
- Improve documentation of `README`s across repository
- Update cudnn version to 8.8, update TRT version to 8.6 across all
files and `README`s
- Update `docker` folder on release branch to use new build system with
custom TRT, cudnn, CUDA, and Python versions
- Update `WORKSPACE` files to use Torch 2.0.1 Release Candidate
@gs-olive gs-olive force-pushed the release_verification branch from 17398a9 to 7673be2 Compare April 27, 2023 00:07
gs-olive
gs-olive commented Apr 27, 2023
View reviewed changes
py/setup.py
@@ -380,7 +386,7 @@ def run(self):
long_description=long_description,
ext_modules=ext_modules,
install_requires=[
"torch==2.0.0",
"torch >=2.0.1,<2.1" if not LEGACY else "torch >=1.13.0,<2.0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated torch requirement to coincide with necessary versions for Legacy/Regular installs.

narendasan
narendasan approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive merged commit 2b70a2f into pytorch:stack_upgrade_1.4 May 2, 2023
@gs-olive gs-olive deleted the release_verification branch May 2, 2023 21:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@peri044 peri044 Awaiting requested review from peri044

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: build system Issues re: Build system component: core Issues re: The core compiler component: fx component: runtime component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @narendasan @facebook-github-bot