Skip to content

fix: Cherry-pick acc convolution fix to release/1.4 #1910

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2023
Merged

fix: Cherry-pick acc convolution fix to release/1.4 #1910

merged 1 commit into from
May 15, 2023

Conversation

gs-olive
Copy link
Collaborator

Description

See #1886 for details

Type of change

  • PR Cherry-Pick

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
    • CI verification
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive requested a review from narendasan May 10, 2023 22:29
@gs-olive gs-olive self-assigned this May 10, 2023
github-actions[bot]
github-actions bot approved these changes May 10, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes May 10, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes May 10, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes May 10, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@github-actions github-actions bot requested a review from yinghai May 10, 2023 22:30
@gs-olive gs-olive removed the request for review from yinghai May 10, 2023 22:31
@gs-olive gs-olive added the release: v1.4 Tagged to be included in v1.4 label May 10, 2023
@github-actions github-actions bot requested a review from yinghai May 10, 2023 22:31
@gs-olive gs-olive removed the request for review from yinghai May 11, 2023 01:28
narendasan
narendasan approved these changes May 15, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive merged commit 8dcb030 into release/1.4 May 15, 2023
@gs-olive gs-olive deleted the acc_ops_release_update branch May 15, 2023 19:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: fx fx release: v1.4 Tagged to be included in v1.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @narendasan @facebook-github-bot