Skip to content

Upstream 3 features to fx_ts_compat: MS, VC, Optimization Level #1935

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
May 31, 2023
Merged

Upstream 3 features to fx_ts_compat: MS, VC, Optimization Level #1935

merged 3 commits into from
May 31, 2023

Conversation

wu6u3tw
Copy link
Contributor

@wu6u3tw wu6u3tw commented May 19, 2023 •
edited
Loading

Description

  • Max Stream,
  • Version Compatability
  • Optimization Level

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added the component: api [Python] Issues re: Python API label May 19, 2023
@github-actions github-actions bot requested a review from narendasan May 19, 2023 17:50
@wu6u3tw
Copy link
Contributor Author

wu6u3tw commented May 19, 2023

@narendasan @nvpohanh for viz

@nvpohanh
Copy link
Contributor

LGTM

@narendasan
Copy link
Collaborator

narendasan commented May 22, 2023 •
edited
Loading

@peri044 can you review?

@nvpohanh
Copy link
Contributor

@peri044 @narendasan Could you review? This is the same as #1926

narendasan
narendasan approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me

@nvpohanh
Copy link
Contributor

@narendasan Could you merge this? We don't have the permission. Thanks

@narendasan narendasan merged commit 4741595 into pytorch:main May 31, 2023
This was referenced Jun 2, 2023
Closed
Merged
narendasan pushed a commit that referenced this pull request Jun 2, 2023
@wu6u3tw @narendasan
Upstream 3 features to fx_ts_compat: MS, VC, Optimization Level (#1935)
840a23c
narendasan pushed a commit that referenced this pull request Jun 2, 2023
@wu6u3tw @narendasan
Upstream 3 features to fx_ts_compat: MS, VC, Optimization Level (#1935)
f1ba637
narendasan pushed a commit that referenced this pull request Jun 3, 2023
@wu6u3tw @narendasan
Upstream 3 features to fx_ts_compat: MS, VC, Optimization Level (#1935)
8b6686a
@gs-olive gs-olive mentioned this pull request Jun 13, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@narendasan narendasan narendasan approved these changes

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wu6u3tw @nvpohanh @narendasan @facebook-github-bot