Skip to content

feat: Add support for passing through build issues in Dynamo compile #1952

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2023
Merged

feat: Add support for passing through build issues in Dynamo compile #1952

merged 1 commit into from
May 26, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented May 25, 2023 •
edited
Loading

Description

  • Add support for pass_through_build_failures keyword arg
  • Restructure testing utilities
  • Add minor typo fixes

Fixes #1927

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive self-assigned this May 25, 2023
@github-actions github-actions bot added the component: api [Python] Issues re: Python API label May 25, 2023
@github-actions github-actions bot requested a review from narendasan May 25, 2023 02:40
@gs-olive gs-olive force-pushed the pass_through_build_failures branch 2 times, most recently from 4ec6f0b to 0f35954 Compare May 25, 2023 03:50
@gs-olive gs-olive mentioned this pull request May 25, 2023
Closed
@gs-olive gs-olive marked this pull request as ready for review May 25, 2023 04:43
@gs-olive gs-olive added the WIP Work is in progress, pull request should not be merged yet label May 25, 2023
@gs-olive gs-olive mentioned this pull request May 25, 2023
Merged
@gs-olive gs-olive force-pushed the pass_through_build_failures branch from 0f35954 to f2f59b1 Compare May 25, 2023 17:13
@gs-olive gs-olive removed the WIP Work is in progress, pull request should not be merged yet label May 25, 2023
@gs-olive gs-olive force-pushed the pass_through_build_failures branch from f2f59b1 to 3b8c865 Compare May 25, 2023 20:01
@gs-olive gs-olive added the WIP Work is in progress, pull request should not be merged yet label May 25, 2023
@gs-olive gs-olive force-pushed the pass_through_build_failures branch 2 times, most recently from 6c423f7 to 52bbed5 Compare May 25, 2023 22:04
@gs-olive gs-olive removed the WIP Work is in progress, pull request should not be merged yet label May 25, 2023
@gs-olive
fix: Add support for passing through build issues
15b7765 
- Add support for `pass_through_build_failures` keyword arg
- Add minor typo fixes
@gs-olive gs-olive force-pushed the pass_through_build_failures branch from 52bbed5 to 15b7765 Compare May 25, 2023 22:15
@gs-olive gs-olive mentioned this pull request May 26, 2023
Merged
narendasan
narendasan approved these changes May 26, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive merged commit e109049 into pytorch:main May 26, 2023
gs-olive added a commit that referenced this pull request May 26, 2023
@gs-olive
feat: Add support for passing through build issues in Dynamo compile (#…
9a77fd7 
…1952)
@gs-olive gs-olive mentioned this pull request May 26, 2023
Merged
narendasan pushed a commit that referenced this pull request May 30, 2023
@gs-olive @narendasan
feat: Add support for passing through build issues in Dynamo compile (#…
0e35e69 
…1952)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@narendasan narendasan narendasan approved these changes

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨[Feature] Allow "pass-through" of engine-build errors in Dynamo
3 participants
@gs-olive @narendasan @facebook-github-bot