Skip to content

fix: Rewrite constant_pad_nd to use a single slice layer for performance #1970

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

mfeliz-cruise
Copy link
Contributor

Description

Rewrite constant_pad_nd converter to use a single slice layer rather than fill and concat. This is similar to what onnx implements here: https://github.com/onnx/onnx-tensorrt/blob/main/builtin_op_importers.cpp#L3249

Functionality covered by existing tests, shows 5ms perf improvement on internal test.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler labels Jun 2, 2023
@github-actions github-actions bot requested a review from narendasan June 2, 2023 01:36
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla signed component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants