Skip to content

tools(opset_coverage): Map default ops to unoverloaded ops #2292

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

narendasan
Copy link
Collaborator

Description

Updates the coverage tool to treat converters for default overloads to the root op name

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Sep 6, 2023
@github-actions github-actions bot requested a review from gs-olive September 6, 2023 00:59
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line with the syntax used in native_functions.yaml, this modification gives more clarity to the operator coverage set. A suggestion for a future improvement might be to provide coverage percentages for just the default operators, since this could give a more accurate view of what's covered.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@narendasan
Copy link
Collaborator Author

In line with the syntax used in native_functions.yaml, this modification gives more clarity to the operator coverage set. A suggestion for a future improvement might be to provide coverage percentages for just the default operators, since this could give a more accurate view of what's covered.

Why do we need to distinguish default operators? Because certain overloads are also part of core_aten so I'd think we would need to treat them equally?

@narendasan narendasan merged commit 67ceab8 into main Sep 6, 2023
@narendasan narendasan deleted the update_coverage_tool branch September 6, 2023 21:48
@gs-olive
Copy link
Collaborator

gs-olive commented Sep 6, 2023

The only reason was to indicate partial support for an operator, even if we don't support every case of it. I assumed we would almost always have the default operator for each unique operation.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants